@caxu-rh you can just make it pretty by default, and remove the flag altogether. I'm of the "jq exists" mindset, where if someone needed to go from raw --> pretty or vice versa, they could pipe it out to jq.

That said, pretty printing is a reasonable default, but I don't think you need to jump through the hoops to offer both here.

[EDIT] Actually, I'll leave having this be configurable up to your discretion. If you want to leave it, pretty as a default makes sense to me (so make the flag --raw instead)

Oh, and if you end up leaving it - feel free to add a config struct as you see fit.

Adjusted to flip the default behavior, forgot to add a config struct - expect another follow-up change.

• Renamed the option to --compact / -c for anyone wanting to keep the compacted output. I figure it is still helpful to keep around in case someone is running this in e.g. some CI flow where some external tools might not be available. I think the naming "compact" is more accurate than "raw" (implies that non-raw output is going through some kind of post-processing, which is not the case) - and I realized that jq's --compact-output option is closer to what we are doing here (--raw-output in jq is also omitting escape chars).
• Added a new struct type NewManifestJSONProcessorFnOptions - open to naming adjustments. The options in this struct are unique for making a ProcessingFunction that outputs a manifest JSON (not generic to ProcessingFunctions in general). To keep things simple for now, this change includes only the struct (avoiding adding e.g. WithCompactOutput() options-style functions).

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caxu-rh, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here